Focus Issue 1332

Discussion related to "Everything" 1.5 Alpha.
Post Reply
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Focus Issue 1332

Post by therube »

Focus Issue 1332

There's probably an issue here


Highlight 2 consecutive files
Rename them such that they're no longer in the current viewport

Hit <sp> to bring to focus

Depending... perhaps where location-wise in the viewport the files started, like maybe at the top, or at the bottom, or ... ?, the 2 files may not end up refocused withing the (new) viewport, as in 1 will be, but the other may not be (& if not, it would be 1 line out of view).


(Don't know if this holds in 1333?)
void
Developer
Posts: 14860
Joined: Fri Oct 16, 2009 11:31 pm

Re: Focus Issue 1332

Post by void »

Thank you for the issue report therube,

Pressing space will bring only the focus into view.

In the next alpha update I will experiment with bringing the focus into the center of the view.
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Re: Focus Issue 1332

Post by therube »

Yes, but I don't recall this having been an issue prior to 1332/1333.
void
Developer
Posts: 14860
Joined: Fri Oct 16, 2009 11:31 pm

Re: Focus Issue 1332

Post by void »

It's always been like this.

I wonder if you previously had keep_result_focus_in_view enabled?
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Re: Focus Issue 1332

Post by therube »

It's always been like this.
You're right.
I wonder if you previously had keep_result_focus_in_view enabled?
I'll have to check.
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Re: Focus Issue 1332

Post by therube »

focus... (rename not required, simply select some items)

if items are out of focus
having scrolled UP in the viewport (so items are moved DOWN)
<sp> brings all items into focus
with 1 un-highlighted line as the last line in the viewport

if items are out of focus
having scrolled DOWN in the viewport (so items are moved UP)
<sp> brings only the last highlighted item into focus - as the top line in the viewport
- all other highlighted lines are above that, out of focus


(heh. i throw around [version] numbers like they're absolutes,
where actually it might just be an action that i hadn't put my
head around yet, or even more oddly, that i hadn't run into - yet)
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Re: Focus Issue 1332

Post by therube »

I wonder if you previously had keep_result_focus_in_view enabled?
I did, up through 1327.
But after that it was reset to 0.

Again, did I knowingly... No. Might I have checked [incorrectly] the value? Possible, but I'm thinking not?

I'll set it back to =1 & see how that fares...
void
Developer
Posts: 14860
Joined: Fri Oct 16, 2009 11:31 pm

Re: Focus Issue 1332

Post by void »

(with 1331, i had occassion to start over fresh, .ini...
actually - the issue with spacing (text_size) threw me,
so i figured i'd start with a fresh .ini & take it from there... guess i could plug in my 1329.ini & test that way...)
1331 ramble

From memory, did you reset your settings here?



I cannot find where we discussed turning on keep_result_focus_in_view..
I vaguely remember talking about keeping the focus in view after a rename.
Maybe via email?
therube
Posts: 4519
Joined: Thu Sep 03, 2009 6:48 pm

Re: Focus Issue 1332

Post by therube »

From memory, did you reset your settings here?
I'm glad your memory is better then mine ;-).

At the time, I didn't "reset", but simply started fresh (so no preexisting .ini).
I then compared new vs. old (.ini) & set diffs to match - for those items that I knew I wanted to have back.
For the items I was not sure of, I would have left them at (1331) defaults, to see how things panned out.


And in that regard, there is, actually was - even before I originally posted this, another nagging focus/highlight issue - but I'm thinking it probably has to do with:
(heh. i throw around [version] numbers [& on what computer I'm doing something on] like they're absolutes,
where actually it might just be an action that i hadn't put my
head around yet, or even more oddly, that i hadn't run into - yet)
And in that regard, I might be somewhat conflating highlighted files & multi-Rename, & how they, after renamed, while they may be physically disbursed (based on new name & sorting), they are all still highlighted, & thinking something like that should apply "everywhere", so when I did a different action, like <sp> to focus, I might have kind of been expecting focus to remain on the "set" of originally highlighted files - where that never did happen at all.
void
Developer
Posts: 14860
Joined: Fri Oct 16, 2009 11:31 pm

Re: Focus Issue 1332

Post by void »

Everything 1.5.0.1334a will now bring the focus into the center of the view.
Post Reply