dupe_lines show wrong line if multiple properties specified

Discussion related to "Everything" 1.5 Alpha.
Post Reply
bit
Posts: 42
Joined: Fri Feb 17, 2023 8:57 am

dupe_lines show wrong line if multiple properties specified

Post by bit »

I want to find files of dupe ext and then sort by path in each dupe group.

Code: Select all

file: z: dupe:ext   sort:ext;path
However the addtional sort will break dupe_lines. It now adds lines on all rows.

Looks like a bug introduced in recent versions.
wrong dupe_lines.png
wrong dupe_lines.png (26.11 KiB) Viewed 1416 times
void
Developer
Posts: 16987
Joined: Fri Oct 16, 2009 11:31 pm

Re: dupe_lines show wrong line if multiple properties specified

Post by void »

Currently, the dupe lines are shown from the current sort (not the dupe properties).

It was the same in previous versions.
Previous version only used first sort property, so it may have worked out.


Intended usage of dupe lines:
Right click the size column -> Find Size Duplicates
---Dupe lines are shown for size duplicates.
Sort by path
---Results still include your duplicated sizes.
---Results are now sorted by path.
---Dupe lines are shown for different paths (not different sizes)



I'll look into using the dupe properties instead of the current sort for the dupe lines.
bit
Posts: 42
Joined: Fri Feb 17, 2023 8:57 am

Re: dupe_lines show wrong line if multiple properties specified

Post by bit »

void wrote: Mon Feb 26, 2024 6:23 am I'll look into using the dupe properties instead of the current sort for the dupe lines.
"dupe_lines" should be added only to differentiate each dupe group.

My use case:
- find files dupes on size
- for each dupe group (same size file), sort them by ext or path, so I can easily tell which one is to be kept (backups) or to be deleted.

Under such case, the colors for dupe groups are works fine, but "dupe_lines" not works as its name implies.

And we have "group_lines", looks pretty much the same effect.

Hope it will be improved.
therube
Posts: 5024
Joined: Thu Sep 03, 2009 6:48 pm

Re: dupe_lines show wrong line if multiple properties specified

Post by therube »

the current sort
Just to note, that also includes Advanced Sort (but the 2 [or 3] sorts selections are AND'ed to determine the sort dupe_lines).
(So if you Advanced Sort; Size & Path, that would find duplicated size files, dupe_lines'd - within the same directory.)
void
Developer
Posts: 16987
Joined: Fri Oct 16, 2009 11:31 pm

Re: dupe_lines show wrong line if multiple properties specified

Post by void »

Everything 1.5.0.1368a improves dupe lines.



Everything will now use only the dupe properties if the current sort starts with the same properties.

For example, Everything will only show dupe lines for ext with the following search:

dupe:ext sort:ext;path



The same applies to right-clicking a column and click Find property dupe, then changing the sort.
You can set a secondary sort with Shift.
This secondary sort is no longer consider when showing dupe lines.



Technically, dupe lines and group lines are the same.
dupe lines will override group lines if you are using a dupe command (dupe: in the search or right-clicking a property and clicking find property duplicates).
bit
Posts: 42
Joined: Fri Feb 17, 2023 8:57 am

Re: dupe_lines show wrong line if multiple properties specified

Post by bit »

void wrote: Thu Feb 29, 2024 5:57 am Everything 1.5.0.1368a

This secondary sort is no longer consider when showing dupe lines.
Found a bug in 1370a about dupe_lines when using a "!" before the 2nd sort:

If I want to find all files with same size but different directories:

Code: Select all

z:\        dupe:size;!path 
result showing addtionanl lines inside this dupe group.
wrong dupe_lines2.png
wrong dupe_lines2.png (20.58 KiB) Viewed 1168 times
Post Reply