[BUG] Found files defaulting to open path

Discussion related to "Everything" 1.5 Alpha.
Post Reply
lifu
Posts: 3
Joined: Tue Jun 15, 2021 11:04 pm

[BUG] Found files defaulting to open path

Post by lifu » Sat Jun 19, 2021 12:51 pm

I' registered to post about this bug. I was hoping to have a more definitive way to replicate it first, but it's unfortunately somewhat random.

After the files are displayed, I double click one, but instead of the default action being performed (open) it instead opens the path.

Image

However, if I right click it a couple times and wait a moment, and then double click it, then it opens normally without opening the path first. Bizarre.

void
Site Admin
Posts: 7179
Joined: Fri Oct 16, 2009 11:31 pm

Re: [BUG] Found files defaulting to open path

Post by void » Sat Jun 19, 2021 12:55 pm

Thank you for the bug report and video lifu,

This is caused by the double_click_path2 ini setting.

Double clicking on the path column will open the path (instead of open the selected file).
The issue is more apparent when full row select is enabled.

Please try disabling double_click_path2:
  • In Everything, type in the following search and press ENTER:
    /double_click_path2=0
  • If successful, you should see double_click_path2=0 in the status bar for a few seconds.

lifu
Posts: 3
Joined: Tue Jun 15, 2021 11:04 pm

Re: [BUG] Found files defaulting to open path

Post by lifu » Sat Jun 19, 2021 2:21 pm

void wrote:
Sat Jun 19, 2021 12:55 pm
Thank you for the bug report and video lifu,

This is caused by the double_click_path2 ini setting.

Double clicking on the path column will open the path (instead of open the selected file).
The issue is more apparent when full row select is enabled.

Please try disabling double_click_path2:
  • In Everything, type in the following search and press ENTER:
    /double_click_path2=0
  • If successful, you should see double_click_path2=0 in the status bar for a few seconds.
Oh, huh. I didn't realize it was being affected by where I was clicking. Here I thought it was just semi-random and difficult to replicate.

Thank you!

void
Site Admin
Posts: 7179
Joined: Fri Oct 16, 2009 11:31 pm

Re: [BUG] Found files defaulting to open path

Post by void » Thu Jun 24, 2021 6:39 am

Everything 1.5.0.1265a adds the double click in the path column option to the UI under Tools -> Options -> Results.

This setting only applies when full row select is enabled.

I'll leave this option disabled by default for now as it really needs a visual cue.
(I am testing underlining the path column text and treating it as a link)

therube
Posts: 3015
Joined: Thu Sep 03, 2009 6:48 pm

Re: [BUG] Found files defaulting to open path

Post by therube » Fri Jun 25, 2021 2:55 pm

1. double-click on Path, opens file rather then Path
double click in the path column option to the UI
I'll leave this option disabled by default for now as it really needs a visual cue.
So the old (& I'd have to say, expected) behavior was to open the path.
But now, you're changing that behavior, by default, to open the file?

I'd think it should be the other way around.
Set the default to the (old) existing behavior & let a user change that if they wish.

(I must say, it threw me for a loop - before finding this thread, when I double-clicked a path & instead of the path opening, the file did.)

void
Site Admin
Posts: 7179
Joined: Fri Oct 16, 2009 11:31 pm

Re: [BUG] Found files defaulting to open path

Post by void » Sat Jun 26, 2021 12:12 am

Everything 1.5.0.1266a reverts the previous change.

To disable double click in path column, set double_click_path2 to: 0

double_click_path2 is enabled by default.

I am working on adding a visual cue to make it clear that you are clicking on the path part.

tuska
Posts: 410
Joined: Thu Jul 13, 2017 9:14 am

Re: [BUG] Found files defaulting to open path

Post by tuska » Sat Jun 26, 2021 7:56 am

Hi,

Code: Select all

Everything.ini
double_click_path2=1
full_row_select=1
full_row_select_double_click_path -> NOT available.
full_row_select_double_click_path=1 does not bring any improvement either.

I would like to note that after clicking on the path, the file is often opened instead
or an attempt is made to open it.

Examples:
D:\TomTom\-default.toc
J:\TomTom\-default.zip
I:\TomTom\-default_20090501_192515.bmp
Various Outlook files (*.msg) -> sometimes path is opened, but sometimes the file.

However, menu "File" - "Open Path" reliably opens the path - for me in Total Commander.

________________________________________________
Windows 10 Pro (x64) Version 21H1 (OS build 19043.1081)
'Everything' 1.5.0.1266a (x64)
Last edited by tuska on Sat Jun 26, 2021 8:36 am, edited 1 time in total.

horst.epp
Posts: 483
Joined: Fri Apr 04, 2014 3:24 pm

Re: [BUG] Found files defaulting to open path

Post by horst.epp » Sat Jun 26, 2021 8:05 am

tuska wrote:
Sat Jun 26, 2021 7:56 am
Hi,

Code: Select all

Everything.ini
double_click_path2=1
full_row_select=1
full_row_select_double_click_path -> NOT available.

I would like to note that after clicking on the path, the file is often opened instead
or an attempt is made to open it.

Examples:
D:\TomTom\-default.toc
J:\TomTom\-default.zip
I:\TomTom\-default_20090501_192515.bmp
Various Outlook files (*.msg) -> sometimes path is opened, but sometimes the file.

However, menu "File" - "Open Path" reliably opens the path - for me in Total Commander.
I can't reproduce that problem with the same setting.
Tested with various files including .msg and some of your examples.
Double clicking the path always opens the path and selects the file in Total Commander.
What I can confirm is that full_row_select_double_click_path is not available in the ini file.

Windows 10 Home x64 Version 21H1 (OS Build 19043.1081)
TC 10.00 x64 / x86
Everything 1.5.0.1266a (x64)

tuska
Posts: 410
Joined: Thu Jul 13, 2017 9:14 am

Re: [BUG] Found files defaulting to open path

Post by tuska » Sat Jun 26, 2021 8:36 am

2horst.epp
Thank you for your post.

I found the cause of the behavior in my case:
I did not click on the pathTEXT, e.g. D:\TomTom but in the same row - still in column "Path" on the empty area.
You have to click directly on the PathText to open the path.
---

2void
It would be desirable for me, if one could click in the path field
(and not only on the name in column "Path) and the path would be opened.

The behavior would then be the same as for the "Name" column. In this case, I also do not have to click directly on the name,
but it is sufficient to click on a free space to the right of the name - still in column "Name".

therube
Posts: 3015
Joined: Thu Sep 03, 2009 6:48 pm

Re: [BUG] Found files defaulting to open path

Post by therube » Mon Jun 28, 2021 3:08 pm

still in column "Path" on the empty area
Do you know offhand if that behavior changed?

I'll note that double-click on any (most likely) column other then Path causes an Open.
(I actually like that. That behavior is not new.)

tuska
Posts: 410
Joined: Thu Jul 13, 2017 9:14 am

Re: [BUG] Found files defaulting to open path

Post by tuska » Mon Jun 28, 2021 7:16 pm

therube wrote:
Mon Jun 28, 2021 3:08 pm
still in column "Path" on the empty area
Do you know offhand if that behavior changed?
Unfortunately no.

I have only now discovered for myself that when displaying files (files: in search bar),
double-clicking on the path opens the folder (in Total Commander for me).

As I have to realize for the second time today, I should have started much earlier, reading forum posts in Everything regularly... :)

therube
Posts: 3015
Joined: Thu Sep 03, 2009 6:48 pm

Re: [BUG] Found files defaulting to open path

Post by therube » Mon Jun 28, 2021 7:47 pm

I'll note...

Depending on the application, & with check boxes in particular, it is (IMO) very ugly when clicking in whitespace effects a checkbox selection/deselection. (Often one, or at least I, will click in whitespace to set focus.)

And with that...

Everything treats (a double-click in) whitespace in Name field as part of the name, which is fine, IMO.
So similarly, it should treat a double-click in whitespace in the Path field as part of the path.

So yes, I'd agree that there is a bug here.

lifu
Posts: 3
Joined: Tue Jun 15, 2021 11:04 pm

Re: [BUG] Found files defaulting to open path

Post by lifu » Wed Jun 30, 2021 8:37 am

I saw that you added a UI option for double clicking the path, but then reverted it. Why revert having it there?

therube
Posts: 3015
Joined: Thu Sep 03, 2009 6:48 pm

Re: [BUG] Found files defaulting to open path

Post by therube » Wed Jun 30, 2021 3:13 pm

I saw that you added a UI option for double clicking the path, but then reverted it. Why revert having it there?
I believe that is an error*, & the UI option was not meant to be removed.
(The default behavior was reverted, but the UI should [but isn't] still be there.)


error*
Everything has always had the GUI setting, "Open Path with double click in path column".
That is no longer there in 1266.

void
Site Admin
Posts: 7179
Joined: Fri Oct 16, 2009 11:31 pm

Re: [BUG] Found files defaulting to open path

Post by void » Tue Jul 06, 2021 7:05 am

Thank you for all the feedback,

The Tools -> Options -> Results -> Open path with double click in path column setting has returned in Everything 1.5.0.1267a.

This option is enabled by default.

A path_hit_text_only ini setting was also added.

Disabling will allow you to double click anywhere in the path column to open the path.

To disable the path_hit_text_only ini setting:
  • In Everything, type in the following search and press ENTER:
    /path_hit_text_only=0
  • If successful, path_hit_text_only=0 is shown in the status bar for a few seconds.
Please let me know if you find the above useful. (I'm not keen on making it the default yet)

There is now a slight visual cue when hovering over the path text. (More work will be done on this)

therube
Posts: 3015
Joined: Thu Sep 03, 2009 6:48 pm

Re: [BUG] Found files defaulting to open path

Post by therube » Tue Jul 06, 2021 3:01 pm

path_hit_text_only=0
IMO, that should be defaulted.
a slight visual cue when hovering over the path text
Oh, I don't like that at all.

Really don't see the point in it?
If you were to do that, then one might want it extended to all columns (not!).

As it is, it's very quirky & annoying.
I'm thinking even more so if full-row-select is enabled.
You're looking at 3 files, 1 2 & 3.
2 is selected, full-row-selected, so the entire row is highlighted.
Then you mouseover 1, in the Path column & a gray blob turns up.
Then you mouseover 3, & 3 happens to have an overflow Path, so first a gray blob turns up - for a moment, then the overflow kicks in replacing the gray blob.

I simply see no need, rationale for it?


FFS: Highlighting makes it difficult to discern just which files are, highlighted.
(Oh, look. I even compared FFS to Everything. And to top it off, I mentioned [& named my picture] 'BRU' instead of FFS :roll:, heh.)

tuska
Posts: 410
Joined: Thu Jul 13, 2017 9:14 am

Re: [BUG] Found files defaulting to open path

Post by tuska » Tue Jul 06, 2021 4:30 pm

2void
Thank you for this new option! :)

Code: Select all

/path_hit_text_only=0
I agree with therube:
therube wrote:
Tue Jul 06, 2021 3:01 pm
path_hit_text_only=0
IMO, that should be defaulted.

void
Site Admin
Posts: 7179
Joined: Fri Oct 16, 2009 11:31 pm

Re: [BUG] Found files defaulting to open path

Post by void » Wed Jul 07, 2021 6:56 am

Thank you for the feedback.

Everything 1.5.0.1268a removes the ugly mouseover background effect in the path column.

I keep finding myself wanting to open the file and not the file location.
I will do more experimenting with path_hit_text_only disabled by default.

Post Reply